Commit 1334be36 authored Nov 17, 2017 by Arnd Bergmann Committed by Linus Torvalds Nov 17, 2017

mm: fix nodemask printing

The cleanup caused build warnings for constant mask pointers:

  mm/mempolicy.c: In function `mpol_to_str':
  ./include/linux/nodemask.h:108:11: warning: the comparison will always evaluate as `true' for the address of `nodes' will never be NULL [-Waddress]

An earlier workaround I suggested was incorporated in the version that
got merged, but that only solved the problem for gcc-7 and higher, while
gcc-4.6 through gcc-6.x still warn.

This changes the printing again to use inline functions that make it
clear to the compiler that the line that does the NULL check has no idea
whether the argument is a constant NULL.

Link: http://lkml.kernel.org/r/20171117101545.119689-1-arnd@arndb.de


Fixes: 0205f755 ("mm: simplify nodemask printing")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Zhangshaokun <zhangshaokun@hisilicon.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a3841f94

include/linux/nodemask.h

+10 −3

Original line number	Diff line number	Diff line
		@@ -104,9 +104,16 @@ extern nodemask_t _unused_nodemask_arg_;
		*
		* Can be used to provide arguments for '%*pb[l]' when printing a nodemask.
		*/
		#define nodemask_pr_args(maskp) \
		((maskp) != NULL) ? MAX_NUMNODES : 0, \
		((maskp) != NULL) ? (maskp)->bits : NULL
		#define nodemask_pr_args(maskp) __nodemask_pr_numnodes(maskp), \
		__nodemask_pr_bits(maskp)
		static inline unsigned int __nodemask_pr_numnodes(const nodemask_t *m)
		{
		return m ? MAX_NUMNODES : 0;
		}
		static inline const unsigned long __nodemask_pr_bits(const nodemask_t m)
		{
		return m ? m->bits : NULL;
		}

		/*
		* The inline keyword gives the compiler room to decide to inline, or

Admin message