Commit 132bf672 authored Nov 06, 2018 by Christophe JAILLET Committed by Darrick J. Wong Nov 06, 2018

xfs: Fix error code in 'xfs_ioc_getbmap()'



In this function, once 'buf' has been allocated, we unconditionally
return 0.
However, 'error' is set to some error codes in several error handling
paths.
Before commit 232b5194 ("xfs: simplify the xfs_getbmap interface")
this was not an issue because all error paths were returning directly,
but now that some cleanup at the end may be needed, we must propagate the
error code.

Fixes: 232b5194 ("xfs: simplify the xfs_getbmap interface")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent 65102238

fs/xfs/xfs_ioctl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1608,7 +1608,7 @@ xfs_ioc_getbmap(
		error = 0;
		out_free_buf:
		kmem_free(buf);
		return 0;
		return error;
		}

		struct getfsmap_info {

Admin message