Commit 132085d8 authored by Thierry Reding's avatar Thierry Reding
Browse files

drm/tegra: Convert output midlayer to helpers 



The output layer was initially designed to help reduce the amount of
code duplicated in output drivers. An unfortunate side-effect of that
was that it turned into a midlayer and it became difficult to make the
output drivers work without bending over backwards to fit into the
midlayer.

This commit starts to convert the midlayer into a helper library by
exporting most of the common functions so that they can be used by the
output drivers directly. Doing so will allow output drivers to reuse
common code paths but more easily override them where necessary.

Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 50a246aa

drivers/gpu/drm/tegra/drm.h

+9 −0
Original line number Diff line number Diff line
@@ -272,6 +272,15 @@ int tegra_output_remove(struct tegra_output *output); 
int tegra_output_init(struct drm_device *drm, struct tegra_output *output);

int tegra_output_exit(struct tegra_output *output);



int tegra_output_connector_get_modes(struct drm_connector *connector);

struct drm_encoder *

tegra_output_connector_best_encoder(struct drm_connector *connector);

enum drm_connector_status

tegra_output_connector_detect(struct drm_connector *connector, bool force);

void tegra_output_connector_destroy(struct drm_connector *connector);



void tegra_output_encoder_destroy(struct drm_encoder *encoder);



/* from dpaux.c */

struct tegra_dpaux;

struct drm_dp_link;

drivers/gpu/drm/tegra/output.c

+12 −12
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@ 
#include <drm/drm_panel.h>

#include "drm.h"



static int tegra_connector_get_modes(struct drm_connector *connector)

int tegra_output_connector_get_modes(struct drm_connector *connector)

{

	struct tegra_output *output = connector_to_output(connector);

	struct edid *edid = NULL;
@@ -57,8 +57,8 @@ static int tegra_connector_mode_valid(struct drm_connector *connector, 
	return status;

}



static struct drm_encoder *

tegra_connector_best_encoder(struct drm_connector *connector)

struct drm_encoder *

tegra_output_connector_best_encoder(struct drm_connector *connector)

{

	struct tegra_output *output = connector_to_output(connector);
@@ -66,13 +66,13 @@ tegra_connector_best_encoder(struct drm_connector *connector) 
}



static const struct drm_connector_helper_funcs connector_helper_funcs = {

	.get_modes = tegra_connector_get_modes,

	.get_modes = tegra_output_connector_get_modes,

	.mode_valid = tegra_connector_mode_valid,

	.best_encoder = tegra_connector_best_encoder,

	.best_encoder = tegra_output_connector_best_encoder,

};



static enum drm_connector_status

tegra_connector_detect(struct drm_connector *connector, bool force)

enum drm_connector_status

tegra_output_connector_detect(struct drm_connector *connector, bool force)

{

	struct tegra_output *output = connector_to_output(connector);

	enum drm_connector_status status = connector_status_unknown;
@@ -98,7 +98,7 @@ tegra_connector_detect(struct drm_connector *connector, bool force) 
	return status;

}



static void tegra_connector_destroy(struct drm_connector *connector)

void tegra_output_connector_destroy(struct drm_connector *connector)

{

	drm_connector_unregister(connector);

	drm_connector_cleanup(connector);
@@ -106,18 +106,18 @@ static void tegra_connector_destroy(struct drm_connector *connector) 


static const struct drm_connector_funcs connector_funcs = {

	.dpms = drm_helper_connector_dpms,

	.detect = tegra_connector_detect,

	.detect = tegra_output_connector_detect,

	.fill_modes = drm_helper_probe_single_connector_modes,

	.destroy = tegra_connector_destroy,

	.destroy = tegra_output_connector_destroy,

};



static void tegra_encoder_destroy(struct drm_encoder *encoder)

void tegra_output_encoder_destroy(struct drm_encoder *encoder)

{

	drm_encoder_cleanup(encoder);

}



static const struct drm_encoder_funcs encoder_funcs = {

	.destroy = tegra_encoder_destroy,

	.destroy = tegra_output_encoder_destroy,

};



static void tegra_encoder_dpms(struct drm_encoder *encoder, int mode)

CRA Git | Maintained and supported by SUSTech CRA and CCSE