Commit 131ce701 authored by Parav Pandit's avatar Parav Pandit Committed by Saeed Mahameed
Browse files

net/mlx5: E-Switch, Remove redundant mc_promisc NULL check 



mc_promisc pointer points to an instance of struct esw_mc_addr allocated
as part of the esw structure.
Hence it cannot be NULL.
Removed such redundant check and assign where it is actually used.

While at it, add comment around legacy mode fields and move mc_promisc
close to other legacy mode structures to improve code redability.

Signed-off-by: default avatarParav Pandit <parav@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 9ddb830a

drivers/net/ethernet/mellanox/mlx5/core/eswitch.c

+2 −2
Original line number Diff line number Diff line
@@ -1900,12 +1900,12 @@ void mlx5_eswitch_disable(struct mlx5_eswitch *esw) 
		 esw->mode == MLX5_ESWITCH_LEGACY ? "LEGACY" : "OFFLOADS",

		 esw->esw_funcs.num_vfs, esw->enabled_vports);



	mc_promisc = &esw->mc_promisc;

	mlx5_eswitch_event_handlers_unregister(esw);



	mlx5_eswitch_disable_pf_vf_vports(esw);



	if (mc_promisc && mc_promisc->uplink_rule)

	mc_promisc = &esw->mc_promisc;

	if (mc_promisc->uplink_rule)

		mlx5_del_flow_rules(mc_promisc->uplink_rule);



	if (esw->mode == MLX5_ESWITCH_LEGACY)

drivers/net/ethernet/mellanox/mlx5/core/eswitch.h

+3 −1
Original line number Diff line number Diff line
@@ -214,8 +214,11 @@ enum { 
struct mlx5_eswitch {

	struct mlx5_core_dev    *dev;

	struct mlx5_nb          nb;

	/* legacy data structures */

	struct mlx5_eswitch_fdb fdb_table;

	struct hlist_head       mc_table[MLX5_L2_ADDR_HASH_SIZE];

	struct esw_mc_addr mc_promisc;

	/* end of legacy */

	struct workqueue_struct *work_queue;

	struct mlx5_vport       *vports;

	u32 flags;
@@ -225,7 +228,6 @@ struct mlx5_eswitch { 
	 * and async SRIOV admin state changes

	 */

	struct mutex            state_lock;

	struct esw_mc_addr	mc_promisc;



	struct {

		bool            enabled;

CRA Git | Maintained and supported by SUSTech CRA and CCSE