Commit 130c5860 authored Apr 29, 2020 by Jason A. Donenfeld Committed by David S. Miller Apr 29, 2020

wireguard: queueing: cleanup ptr_ring in error path of packet_queue_init



Prior, if the alloc_percpu of packet_percpu_multicore_worker_alloc
failed, the previously allocated ptr_ring wouldn't be freed. This commit
adds the missing call to ptr_ring_cleanup in the error case.

Reported-by: Sultan Alsawaf <sultan@kerneltoast.com>
Fixes: e7096c13 ("net: WireGuard secure network tunnel")
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d6833e42

drivers/net/wireguard/queueing.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -35,8 +35,10 @@ int wg_packet_queue_init(struct crypt_queue *queue, work_func_t function,
		if (multicore) {
		queue->worker = wg_packet_percpu_multicore_worker_alloc(
		function, queue);
		if (!queue->worker)
		if (!queue->worker) {
		ptr_ring_cleanup(&queue->ring, NULL);
		return -ENOMEM;
		}
		} else {
		INIT_WORK(&queue->work, function);
		}

Admin message