Commit 13071f0a authored by Alexey Dobriyan's avatar Alexey Dobriyan Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (5076): Cpia.c: buffer overflow 



If assigned minor is 10 or greater, terminator will be put beyound the end.

Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent c74e0062

drivers/media/video/cpia.c

+4 −4
Original line number Diff line number Diff line
@@ -1350,13 +1350,13 @@ out: 


static void create_proc_cpia_cam(struct cam_data *cam)

{

	char name[7];

	char name[5 + 1 + 10 + 1];

	struct proc_dir_entry *ent;



	if (!cpia_proc_root || !cam)

		return;



	sprintf(name, "video%d", cam->vdev.minor);

	snprintf(name, sizeof(name), "video%d", cam->vdev.minor);



	ent = create_proc_entry(name, S_IFREG|S_IRUGO|S_IWUSR, cpia_proc_root);

	if (!ent)
@@ -1376,12 +1376,12 @@ static void create_proc_cpia_cam(struct cam_data *cam) 


static void destroy_proc_cpia_cam(struct cam_data *cam)

{

	char name[7];

	char name[5 + 1 + 10 + 1];



	if (!cam || !cam->proc_entry)

		return;



	sprintf(name, "video%d", cam->vdev.minor);

	snprintf(name, sizeof(name), "video%d", cam->vdev.minor);

	remove_proc_entry(name, cpia_proc_root);

	cam->proc_entry = NULL;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE