Commit 12fb8c15 authored Mar 18, 2010 by Alan Stern Committed by James Bottomley Apr 11, 2010

[SCSI] don't kfree an initialized struct device



This patch (as1359) fixes a bug in scsi_alloc_target().  After a
device structure has been initialized (and especially after its name
has been set), it must not be freed directly.  One has to call
put_device() instead.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

parent 1821438a

drivers/scsi/scsi_scan.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -459,8 +459,7 @@ static struct scsi_target scsi_alloc_target(struct device parent,
		found_target->reap_ref++;
		spin_unlock_irqrestore(shost->host_lock, flags);
		if (found_target->state != STARGET_DEL) {
		put_device(parent);
		kfree(starget);
		put_device(dev);
		return found_target;
		}
		/* Unfortunately, we found a dying target; need to

Admin message