Commit 12e0f438 authored May 22, 2015 by Takashi Sakamoto Committed by Takashi Iwai May 24, 2015

ALSA: firewire-lib: use dev_err() when detecting incoming streaming error



When detecting invalid value in 'dbs' field of CIP header or packet
discontinuity, current implementation reports the status by err_info().
In most cases this state is caused by model-specific issue due to
vendor's customization and should be reported to developers.

This commit use dev_err() instead of dev_info() for this purpose.
In the cases, packet streaming is aborted, thus no message floading
occurs.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 9a2820c1

sound/firewire/amdtp.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -723,7 +723,7 @@ static int handle_in_packet(struct amdtp_stream *s,
		(cip_header[0] & CIP_DBS_MASK) >> CIP_DBS_SHIFT;
		/* avoid division by zero */
		if (data_block_quadlets == 0) {
		dev_info_ratelimited(&s->unit->device,
		dev_err(&s->unit->device,
		"Detect invalid value in dbs field: %08X\n",
		cip_header[0]);
		return -EIO;
		@@ -756,7 +756,7 @@ static int handle_in_packet(struct amdtp_stream *s,
		}

		if (lost) {
		dev_info(&s->unit->device,
		dev_err(&s->unit->device,
		"Detect discontinuity of CIP: %02X %02X\n",
		s->data_block_counter, data_block_counter);
		return -EIO;

Admin message