Commit 12dfd78e authored Apr 21, 2020 by Jere Leppänen Committed by David S. Miller Apr 22, 2020

sctp: Fix SHUTDOWN CTSN Ack in the peer restart case



When starting shutdown in sctp_sf_do_dupcook_a(), get the value for
SHUTDOWN Cumulative TSN Ack from the new association, which is
reconstructed from the cookie, instead of the old association, which
the peer doesn't have anymore.

Otherwise the SHUTDOWN is either ignored or replied to with an ABORT
by the peer because CTSN Ack doesn't match the peer's Initial TSN.

Fixes: bdf6fa52 ("sctp: handle association restarts when the socket is closed.")
Signed-off-by: Jere Leppänen <jere.leppanen@nokia.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 145cb2f7

net/sctp/sm_make_chunk.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -858,7 +858,11 @@ struct sctp_chunk sctp_make_shutdown(const struct sctp_association asoc,
		struct sctp_chunk *retval;
		__u32 ctsn;

		if (chunk && chunk->asoc)
		ctsn = sctp_tsnmap_get_ctsn(&chunk->asoc->peer.tsn_map);
		else
		ctsn = sctp_tsnmap_get_ctsn(&asoc->peer.tsn_map);

		shut.cum_tsn_ack = htonl(ctsn);

		retval = sctp_make_control(asoc, SCTP_CID_SHUTDOWN, 0,

Admin message