Commit 12d6f669 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Jason Gunthorpe
Browse files

RDMA/nes: Delete impossible debug prints 



The pci-core and net-core logic ensure that parameters provided
to nes_probe() and nes_netdev_open() are valid, hence the assert
print are not possible.

Cc: Faisal Latif <faisal.latif@intel.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Reviewed-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent b3b43483

drivers/infiniband/hw/nes/nes.c

+0 −3
Original line number Diff line number Diff line
@@ -456,9 +456,6 @@ static int nes_probe(struct pci_dev *pcidev, const struct pci_device_id *ent) 
	void __iomem *mmio_regs = NULL;

	u8 hw_rev;



	assert(pcidev != NULL);

	assert(ent != NULL);



	printk(KERN_INFO PFX "NetEffect RNIC driver v%s loading. (%s)\n",

			DRV_VERSION, pci_name(pcidev));

drivers/infiniband/hw/nes/nes.h

+0 −9
Original line number Diff line number Diff line
@@ -149,18 +149,9 @@ do { \ 
		printk(KERN_ERR PFX "%s[%u]: " fmt, __func__, __LINE__, ##args); \

} while (0)



#define assert(expr) \

do { \

	if (!(expr)) { \

		printk(KERN_ERR PFX "Assertion failed! %s, %s, %s, line %d\n", \

			   #expr, __FILE__, __func__, __LINE__); \

	} \

} while (0)



#define NES_EVENT_TIMEOUT   1200000

#else

#define nes_debug(level, fmt, args...) no_printk(fmt, ##args)

#define assert(expr)          do {} while (0)



#define NES_EVENT_TIMEOUT   100000

#endif

drivers/infiniband/hw/nes/nes_nic.c

+0 −2
Original line number Diff line number Diff line
@@ -146,8 +146,6 @@ static int nes_netdev_open(struct net_device *netdev) 
	struct list_head *list_pos, *list_temp;

	unsigned long flags;



	assert(nesdev != NULL);



	if (nesvnic->netdev_open == 1)

		return 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE