Commit 12b3052c authored by Eric Paris's avatar Eric Paris Committed by Linus Torvalds
Browse files

capabilities/syslog: open code cap_syslog logic to fix build failure 



The addition of CONFIG_SECURITY_DMESG_RESTRICT resulted in a build
failure when CONFIG_PRINTK=n.  This is because the capabilities code
which used the new option was built even though the variable in question
didn't exist.

The patch here fixes this by moving the capabilities checks out of the
LSM and into the caller.  All (known) LSMs should have been calling the
capabilities hook already so it actually makes the code organization
better to eliminate the hook altogether.

Signed-off-by: default avatarEric Paris <eparis@redhat.com>
Acked-by: default avatarJames Morris <jmorris@namei.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6800e4c0

include/linux/security.h

+4 −5
Original line number Diff line number Diff line
@@ -77,7 +77,6 @@ extern int cap_task_prctl(int option, unsigned long arg2, unsigned long arg3, 
extern int cap_task_setscheduler(struct task_struct *p);

extern int cap_task_setioprio(struct task_struct *p, int ioprio);

extern int cap_task_setnice(struct task_struct *p, int nice);

extern int cap_syslog(int type, bool from_file);

extern int cap_vm_enough_memory(struct mm_struct *mm, long pages);



struct msghdr;
@@ -1388,7 +1387,7 @@ struct security_operations { 
	int (*sysctl) (struct ctl_table *table, int op);

	int (*quotactl) (int cmds, int type, int id, struct super_block *sb);

	int (*quota_on) (struct dentry *dentry);

	int (*syslog) (int type, bool from_file);

	int (*syslog) (int type);

	int (*settime) (struct timespec *ts, struct timezone *tz);

	int (*vm_enough_memory) (struct mm_struct *mm, long pages);
@@ -1671,7 +1670,7 @@ int security_real_capable_noaudit(struct task_struct *tsk, int cap); 
int security_sysctl(struct ctl_table *table, int op);

int security_quotactl(int cmds, int type, int id, struct super_block *sb);

int security_quota_on(struct dentry *dentry);

int security_syslog(int type, bool from_file);

int security_syslog(int type);

int security_settime(struct timespec *ts, struct timezone *tz);

int security_vm_enough_memory(long pages);

int security_vm_enough_memory_mm(struct mm_struct *mm, long pages);
@@ -1901,9 +1900,9 @@ static inline int security_quota_on(struct dentry *dentry) 
	return 0;

}



static inline int security_syslog(int type, bool from_file)

static inline int security_syslog(int type)

{

	return cap_syslog(type, from_file);

	return 0;

}



static inline int security_settime(struct timespec *ts, struct timezone *tz)

kernel/printk.c

+14 −1
Original line number Diff line number Diff line
@@ -274,7 +274,20 @@ int do_syslog(int type, char __user *buf, int len, bool from_file) 
	char c;

	int error = 0;



	error = security_syslog(type, from_file);

	/*

	 * If this is from /proc/kmsg we only do the capabilities checks

	 * at open time.

	 */

	if (type == SYSLOG_ACTION_OPEN || !from_file) {

		if (dmesg_restrict && !capable(CAP_SYS_ADMIN))

			return -EPERM;

		if ((type != SYSLOG_ACTION_READ_ALL &&

		     type != SYSLOG_ACTION_SIZE_BUFFER) &&

		    !capable(CAP_SYS_ADMIN))

			return -EPERM;

	}



	error = security_syslog(type);

	if (error)

		return error;

security/capability.c

+5 −0
Original line number Diff line number Diff line
@@ -17,6 +17,11 @@ static int cap_sysctl(ctl_table *table, int op) 
	return 0;

}



static int cap_syslog(int type)

{

	return 0;

}



static int cap_quotactl(int cmds, int type, int id, struct super_block *sb)

{

	return 0;

security/commoncap.c

+0 −21
Original line number Diff line number Diff line
@@ -27,7 +27,6 @@ 
#include <linux/sched.h>

#include <linux/prctl.h>

#include <linux/securebits.h>

#include <linux/syslog.h>



/*

 * If a non-root user executes a setuid-root binary in
@@ -883,26 +882,6 @@ error: 
	return error;

}



/**

 * cap_syslog - Determine whether syslog function is permitted

 * @type: Function requested

 * @from_file: Whether this request came from an open file (i.e. /proc)

 *

 * Determine whether the current process is permitted to use a particular

 * syslog function, returning 0 if permission is granted, -ve if not.

 */

int cap_syslog(int type, bool from_file)

{

	if (type != SYSLOG_ACTION_OPEN && from_file)

		return 0;

	if (dmesg_restrict && !capable(CAP_SYS_ADMIN))

		return -EPERM;

	if ((type != SYSLOG_ACTION_READ_ALL &&

	     type != SYSLOG_ACTION_SIZE_BUFFER) && !capable(CAP_SYS_ADMIN))

		return -EPERM;

	return 0;

}



/**

 * cap_vm_enough_memory - Determine whether a new virtual mapping is permitted

 * @mm: The VM space in which the new mapping is to be made

security/security.c

+2 −2
Original line number Diff line number Diff line
@@ -197,9 +197,9 @@ int security_quota_on(struct dentry *dentry) 
	return security_ops->quota_on(dentry);

}



int security_syslog(int type, bool from_file)

int security_syslog(int type)

{

	return security_ops->syslog(type, from_file);

	return security_ops->syslog(type);

}



int security_settime(struct timespec *ts, struct timezone *tz)

CRA Git | Maintained and supported by SUSTech CRA and CCSE