sched/pelt: Fix update_blocked_averages() for RT and DL classes (12b04875) · Commits · 戴 / test

update_blocked_averages() is called to periodiccally decay the stalled load of idle CPUs and to sync all loads before running load balance. When cfs rq is idle, it trigs a load balance during pick_next_task_fair() in order to potentially pull tasks and to use this newly idle CPU. This load balance happens whereas prev task from another class has not been put and its utilization updated yet. This may lead to wrongly account running time as idle time for RT or DL classes. Test that no RT or DL task is running when updating their utilization in update_blocked_averages(). We still update RT and DL utilization instead of simply skipping them to make sure that all metrics are synced when used during load balance. Signed-off-by:

Vincent Guittot <vincent.guittot@linaro.org> Signed-off-by:

Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Fixes: ("sched/rt: Add rt_rq utilization tracking") Fixes: ("sched/dl: Add dl_rq utilization tracking") Link: http://lkml.kernel.org/r/1535728975-22799-1-git-send-email-vincent.guittot@linaro.org Signed-off-by:

Ingo Molnar <mingo@kernel.org>

kernel/sched/fair.c

+10 −4

Original line number	Diff line number	Diff line
		@@ -7263,6 +7263,7 @@ static void update_blocked_averages(int cpu)
		{
		struct rq *rq = cpu_rq(cpu);
		struct cfs_rq cfs_rq, pos;
		const struct sched_class *curr_class;
		struct rq_flags rf;
		bool done = true;

		@@ -7299,8 +7300,10 @@ static void update_blocked_averages(int cpu)
		if (cfs_rq_has_blocked(cfs_rq))
		done = false;
		}
		update_rt_rq_load_avg(rq_clock_task(rq), rq, 0);
		update_dl_rq_load_avg(rq_clock_task(rq), rq, 0);

		curr_class = rq->curr->sched_class;
		update_rt_rq_load_avg(rq_clock_task(rq), rq, curr_class == &rt_sched_class);
		update_dl_rq_load_avg(rq_clock_task(rq), rq, curr_class == &dl_sched_class);
		update_irq_load_avg(rq, 0);
		/* Don't need periodic decay once load/util_avg are null */
		if (others_have_blocked(rq))
		@@ -7365,13 +7368,16 @@ static inline void update_blocked_averages(int cpu)
		{
		struct rq *rq = cpu_rq(cpu);
		struct cfs_rq *cfs_rq = &rq->cfs;
		const struct sched_class *curr_class;
		struct rq_flags rf;

		rq_lock_irqsave(rq, &rf);
		update_rq_clock(rq);
		update_cfs_rq_load_avg(cfs_rq_clock_task(cfs_rq), cfs_rq);
		update_rt_rq_load_avg(rq_clock_task(rq), rq, 0);
		update_dl_rq_load_avg(rq_clock_task(rq), rq, 0);

		curr_class = rq->curr->sched_class;
		update_rt_rq_load_avg(rq_clock_task(rq), rq, curr_class == &rt_sched_class);
		update_dl_rq_load_avg(rq_clock_task(rq), rq, curr_class == &dl_sched_class);
		update_irq_load_avg(rq, 0);
		#ifdef CONFIG_NO_HZ_COMMON
		rq->last_blocked_load_update_tick = jiffies;

Admin message