Commit 12a5105e authored by Viresh Kumar's avatar Viresh Kumar Committed by Samuel Ortiz
Browse files

mfd: stmpe: Get rid of irq_invert_polarity 

Since the very first patch, stmpe core driver is using irq_invert_polarity as
part of platform data. But, nobody is actually using it in kernel till now.

Also, this is not something part of hardware specs, but is included to cater
some board mistakes or quirks.

So, better get rid of it. This is earlier discussed here:

https://lkml.org/lkml/2012/11/27/636



Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Acked-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 4e1328be

drivers/mfd/stmpe.c

+0 −7
Original line number Diff line number Diff line
@@ -953,13 +953,6 @@ static int __devinit stmpe_chip_init(struct stmpe *stmpe) 
			else

				icr |= STMPE_ICR_LSB_HIGH;

		}



		if (stmpe->pdata->irq_invert_polarity) {

			if (id == STMPE801_ID)

				icr ^= STMPE801_REG_SYS_CTRL_INT_HI;

			else

				icr ^= STMPE_ICR_LSB_HIGH;

		}

	}



	if (stmpe->pdata->autosleep) {

include/linux/mfd/stmpe.h

+0 −2
Original line number Diff line number Diff line
@@ -190,7 +190,6 @@ struct stmpe_ts_platform_data { 
 * @id: device id to distinguish between multiple STMPEs on the same board

 * @blocks: bitmask of blocks to enable (use STMPE_BLOCK_*)

 * @irq_trigger: IRQ trigger to use for the interrupt to the host

 * @irq_invert_polarity: IRQ line is connected with reversed polarity

 * @autosleep: bool to enable/disable stmpe autosleep

 * @autosleep_timeout: inactivity timeout in milliseconds for autosleep

 * @irq_base: base IRQ number.  %STMPE_NR_IRQS irqs will be used, or
@@ -207,7 +206,6 @@ struct stmpe_platform_data { 
	unsigned int blocks;

	int irq_base;

	unsigned int irq_trigger;

	bool irq_invert_polarity;

	bool autosleep;

	bool irq_over_gpio;

	int irq_gpio;

CRA Git | Maintained and supported by SUSTech CRA and CCSE