Commit 127067a9 authored Jul 19, 2007 by Rafael J. Wysocki Committed by Linus Torvalds Jul 19, 2007

swsusp: remove incorrect code from user.c

In the face of the recent change of suspend code ordering (cf.
http://marc.info/?l=linux-acpi&m=117938245931603&w=2

) we should also modify
the code ordering in swsusp so that hibernation_ops->prepare() is executed
after device_suspend().

However, for this purpose it seems reasonable to eliminate the code
duplication between kernel/power/disk.c and kernel/power/user.c first.  By
eliminating it we can reduce the size of user.c quite substantially and remove
the maintenance difficulty with making essentially the same changes in two
different places.

Moreover, we should also remove the calls to "platform" functions from the
restore code path, since it doesn't carry out any power transition of the
system, but we generally need to disable the GPEs before the restore if the
'platform' hibernation mode has been used.  To do this, we can introduce two
new hibernation_ops to be used in the restore code.

This patch:

Make the code hibernation code in kernel/power/user.c be functionally
equivalent to the corresponding code in kernel/power/disk.c , as it should be.

The calls to the platform functions removed by this patch are incorrect.  They
should be replaced with some other "platform" invocations that will be
introduced in one of the subsequent patches.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Pavel Machek <pavel@ucw.cz>
Cc: Nigel Cunningham <nigel@nigel.suspend2.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a0349828

kernel/power/user.c

+4 −13

Original line number	Diff line number	Diff line
		@@ -181,34 +181,25 @@ static inline int snapshot_suspend(int platform_suspend)
		return error;
		}

		static inline int snapshot_restore(int platform_suspend)
		static inline int snapshot_restore(void)
		{
		int error;

		mutex_lock(&pm_mutex);
		pm_prepare_console();
		if (platform_suspend) {
		error = platform_prepare();
		if (error)
		goto Finish;
		}
		suspend_console();
		error = device_suspend(PMSG_PRETHAW);
		if (error)
		goto Resume_devices;
		goto Finish;

		error = disable_nonboot_cpus();
		if (!error)
		error = swsusp_resume();

		enable_nonboot_cpus();
		Resume_devices:
		if (platform_suspend)
		platform_finish();

		Finish:
		device_resume();
		resume_console();
		Finish:
		pm_restore_console();
		mutex_unlock(&pm_mutex);
		return error;
		@@ -274,7 +265,7 @@ static int snapshot_ioctl(struct inode inode, struct file filp,
		error = -EPERM;
		break;
		}
		error = snapshot_restore(data->platform_suspend);
		error = snapshot_restore();
		break;

		case SNAPSHOT_FREE:

Admin message