Commit 126c97f4 authored Aug 23, 2018 by Nicholas Mc Guire Committed by Steve French Aug 23, 2018

cifs: check kmalloc before use



The kmalloc was not being checked - if it fails issue a warning
and return -ENOMEM to the caller.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: b8da344b ("cifs: dynamic allocation of ntlmssp blob")
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
cc: Stable <stable@vger.kernel.org>`

parent e6c47dd0

fs/cifs/sess.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -398,6 +398,12 @@ int build_ntlmssp_auth_blob(unsigned char **pbuffer,
		goto setup_ntlmv2_ret;
		}
		*pbuffer = kmalloc(size_of_ntlmssp_blob(ses), GFP_KERNEL);
		if (!*pbuffer) {
		rc = -ENOMEM;
		cifs_dbg(VFS, "Error %d during NTLMSSP allocation\n", rc);
		*buflen = 0;
		goto setup_ntlmv2_ret;
		}
		sec_blob = (AUTHENTICATE_MESSAGE )pbuffer;

		memcpy(sec_blob->Signature, NTLMSSP_SIGNATURE, 8);

Admin message