Commit 126976c7 authored Jan 10, 2010 by Dave Chinner Committed by Alex Elder Jan 15, 2010

xfs: Remove inode iolock held check during allocation



lockdep complains about a the lock not being initialised as we do an
ASSERT based check that the lock is not held before we initialise it
to catch inodes freed with the lock held.

lockdep does this check for us in the lock initialisation code, so
remove the ASSERT to stop the lockdep warning.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>

parent 57817c68

fs/xfs/xfs_iget.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -73,7 +73,6 @@ xfs_inode_alloc(
		ASSERT(atomic_read(&ip->i_pincount) == 0);
		ASSERT(!spin_is_locked(&ip->i_flags_lock));
		ASSERT(completion_done(&ip->i_flush));
		ASSERT(!rwsem_is_locked(&ip->i_iolock.mr_lock));

		mrlock_init(&ip->i_iolock, MRLOCK_BARRIER, "xfsio", ip->i_ino);

Admin message