cifs: implement drop_inode superblock op (12420ac3) · Commits · 戴 / test

The standard behavior for drop_inode is to delete the inode when the last reference to it is put and the nlink count goes to 0. This helps keep inodes that are still considered "not deleted" in cache as long as possible even when there aren't dentries attached to them. When server inode numbers are disabled, it's not possible for cifs_iget to ever match an existing inode (since inode numbers are generated via iunique). In this situation, cifs can keep a lot of inodes in cache that will never be used again. Implement a drop_inode routine that deletes the inode if server inode numbers are disabled on the mount. This helps keep the cifs inode caches down to a more manageable size when server inode numbers are disabled. Signed-off-by:

Jeff Layton <jlayton@redhat.com> Signed-off-by:

Steve French <sfrench@us.ibm.com>

fs/cifs/cifsfs.c

+13 −3

Original line number	Diff line number	Diff line
		@@ -473,14 +473,24 @@ static int cifs_remount(struct super_block sb, int flags, char *data)
		return 0;
		}

		void cifs_drop_inode(struct inode *inode)
		{
		struct cifs_sb_info *cifs_sb = CIFS_SB(inode->i_sb);

		if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_SERVER_INUM)
		return generic_drop_inode(inode);

		return generic_delete_inode(inode);
		}

		static const struct super_operations cifs_super_ops = {
		.put_super = cifs_put_super,
		.statfs = cifs_statfs,
		.alloc_inode = cifs_alloc_inode,
		.destroy_inode = cifs_destroy_inode,
		/* .drop_inode = generic_delete_inode,
		.delete_inode = cifs_delete_inode, / / Do not need above two
		functions unless later we add lazy close of inodes or unless the
		.drop_inode = cifs_drop_inode,
		/* .delete_inode = cifs_delete_inode, / / Do not need above
		function unless later we add lazy close of inodes or unless the
		kernel forgets to call us with the same number of releases (closes)
		as opens */
		.show_options = cifs_show_options,

Admin message