Commit 123c0aab authored Oct 20, 2017 by Colin Ian King Committed by Greg Kroah-Hartman Nov 03, 2017

staging: rtl8188eu: avoid a null dereference on pmlmepriv

There is a check on pmlmepriv before dereferencing it when
vfree'ing pmlmepriv->free_bss_buf however the previous call
to rtw_free_mlme_priv_ie_data deferences pmlmepriv causing
a null pointer deference if it is null. Avoid this by also
calling rtw_free_mlme_priv_ie_data if the pointer is non-null.

Detected by CoverityScan, CID#1230262 ("Dereference before null check")
Fixes: 7b464c9f ("staging: r8188eu: Add files for new driver - part 4")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 66d32fdc

drivers/staging/rtl8188eu/core/rtw_mlme.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -106,11 +106,11 @@ void rtw_free_mlme_priv_ie_data(struct mlme_priv *pmlmepriv)

		void rtw_free_mlme_priv(struct mlme_priv *pmlmepriv)
		{
		if (pmlmepriv) {
		rtw_free_mlme_priv_ie_data(pmlmepriv);

		if (pmlmepriv)
		vfree(pmlmepriv->free_bss_buf);
		}
		}

		struct wlan_network _rtw_alloc_network(struct mlme_priv pmlmepriv)
		/* _queue free_queue) /

Admin message