Commit 11f57ced authored Feb 10, 2007 by Ingo Molnar Committed by Linus Torvalds Feb 11, 2007

[PATCH] audit: fix audit_filter_user_rules() initialization bug



gcc emits this warning:

 kernel/auditfilter.c: In function 'audit_filter_user':
 kernel/auditfilter.c:1611: warning: 'state' is used uninitialized in this function

I tend to agree with gcc - there are a couple of plausible exit paths from
audit_filter_user_rules() where it does not set 'state', keeping the
variable uninitialized.  For example if a filter rule has an AUDIT_POSSIBLE
action.  Initialize to 'wont audit'.  Fix whitespace damage too.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent ead6596b

kernel/auditfilter.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1601,8 +1601,8 @@ static int audit_filter_user_rules(struct netlink_skb_parms *cb,

		int audit_filter_user(struct netlink_skb_parms *cb, int type)
		{
		enum audit_state state = AUDIT_DISABLED;
		struct audit_entry *e;
		enum audit_state state;
		int ret = 1;

		rcu_read_lock();

Admin message