Commit 11e93130 authored Dec 29, 2008 by Rafael J. Wysocki Committed by Len Brown Dec 30, 2008

ACPI: Do not modify SCI_EN directly



According to the ACPI specification the SCI_EN flag is controlled by
the hardware, which sets this flag to inform the kernel that ACPI is
enabled.  For this reason, we shouldn't try to modify SCI_EN
directly.  Also, we don't need to do it in irqrouter_resume(), since
lower-level resume code takes care of enabling ACPI in case it hasn't
been enabled by the BIOS before passing control to the kernel (which
by the way is against the ACPI specification).

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Len Brown <len.brown@intel.com>

parent 816bb611

drivers/acpi/pci_link.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -796,10 +796,6 @@ static int irqrouter_resume(struct sys_device *dev)
		struct list_head *node = NULL;
		struct acpi_pci_link *link = NULL;


		/* Make sure SCI is enabled again (Apple firmware bug?) */
		acpi_set_register(ACPI_BITREG_SCI_ENABLE, 1);

		list_for_each(node, &acpi_link.entries) {
		link = list_entry(node, struct acpi_pci_link, node);
		if (!link) {

Admin message