mlx4_core: Move table_find from fmr_alloc to fmr_enable (11e75a74) · Commits · 戴 / test

mlx4_table_find (for FMR MPTs) requires that ICM memory already be mapped. Before this fix, FMR allocation depended on ICM memory already being mapped for the MPT entry. If all currently mapped entries are taken, the find operation fails (even if the MPT ICM table still had more entries, which were just not mapped yet). This fix moves the mpt find operation to fmr_enable, to guarantee that any required ICM memory mapping has already occurred. Found by Oren Duer of Mellanox. Signed-off-by:

Jack Morgenstein <jackm@dev.mellanox.co.il> Signed-off-by:

Roland Dreier <rolandd@cisco.com>

drivers/net/mlx4/mr.c

+13 −8

Original line number	Diff line number	Diff line
		@@ -578,13 +578,6 @@ int mlx4_fmr_alloc(struct mlx4_dev *dev, u32 pd, u32 access, int max_pages,
		goto err_free;
		}

		fmr->mpt = mlx4_table_find(&priv->mr_table.dmpt_table,
		key_to_hw_index(fmr->mr.key), NULL);
		if (!fmr->mpt) {
		err = -ENOMEM;
		goto err_free;
		}

		return 0;

		err_free:
		@@ -595,7 +588,19 @@ EXPORT_SYMBOL_GPL(mlx4_fmr_alloc);

		int mlx4_fmr_enable(struct mlx4_dev dev, struct mlx4_fmr fmr)
		{
		return mlx4_mr_enable(dev, &fmr->mr);
		struct mlx4_priv *priv = mlx4_priv(dev);
		int err;

		err = mlx4_mr_enable(dev, &fmr->mr);
		if (err)
		return err;

		fmr->mpt = mlx4_table_find(&priv->mr_table.dmpt_table,
		key_to_hw_index(fmr->mr.key), NULL);
		if (!fmr->mpt)
		return -ENOMEM;

		return 0;
		}
		EXPORT_SYMBOL_GPL(mlx4_fmr_enable);

Admin message