Commit 11dbaa8c authored by Paul E. McKenney's avatar Paul E. McKenney Committed by Paul E. McKenney
Browse files

rcu: Fix idle-task checks 



RCU has traditionally relied on idle_cpu() to determine whether a given
CPU is running in the context of an idle task, but commit 908a3283
(Fix idle_cpu()) has invalidated this approach.  After commit 908a3283,
idle_cpu() will return true if the current CPU is currently running the
idle task, and will be doing so for the foreseeable future.  RCU instead
needs to know whether or not the current CPU is currently running the
idle task, regardless of what the near future might bring.

This commit therefore switches from idle_cpu() to "current->pid != 0".

Reported-by: default avatarWu Fengguang <fengguang.wu@intel.com>
Suggested-by: default avatarCarsten Emde <C.Emde@osadl.org>
Signed-off-by: default avatarPaul E. McKenney <paul.mckenney@linaro.org>
Acked-by: default avatarSteven Rostedt <rostedt@goodmis.org>
Tested-by: default avatarWu Fengguang <fengguang.wu@intel.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
parent aea1b35e

kernel/rcutiny.c

+2 −2
Original line number Diff line number Diff line
@@ -64,7 +64,7 @@ static void rcu_idle_enter_common(long long oldval) 
		return;

	}

	RCU_TRACE(trace_rcu_dyntick("Start", oldval, rcu_dynticks_nesting));

	if (!idle_cpu(smp_processor_id())) {

	if (current->pid != 0) {

		struct task_struct *idle = idle_task(smp_processor_id());



		RCU_TRACE(trace_rcu_dyntick("Error on entry: not idle task",
@@ -118,7 +118,7 @@ static void rcu_idle_exit_common(long long oldval) 
		return;

	}

	RCU_TRACE(trace_rcu_dyntick("End", oldval, rcu_dynticks_nesting));

	if (!idle_cpu(smp_processor_id())) {

	if (current->pid != 0) {

		struct task_struct *idle = idle_task(smp_processor_id());



		RCU_TRACE(trace_rcu_dyntick("Error on exit: not idle task",

kernel/rcutree.c

+2 −2
Original line number Diff line number Diff line
@@ -355,7 +355,7 @@ static void rcu_idle_enter_common(struct rcu_dynticks *rdtp, long long oldval) 
		return;

	}

	trace_rcu_dyntick("Start", oldval, rdtp->dynticks_nesting);

	if (!idle_cpu(smp_processor_id())) {

	if (current->pid != 0) {

		struct task_struct *idle = idle_task(smp_processor_id());



		trace_rcu_dyntick("Error on entry: not idle task",
@@ -449,7 +449,7 @@ static void rcu_idle_exit_common(struct rcu_dynticks *rdtp, long long oldval) 
	smp_mb__after_atomic_inc();  /* See above. */

	WARN_ON_ONCE(!(atomic_read(&rdtp->dynticks) & 0x1));

	trace_rcu_dyntick("End", oldval, rdtp->dynticks_nesting);

	if (!idle_cpu(smp_processor_id())) {

	if (current->pid != 0) {

		struct task_struct *idle = idle_task(smp_processor_id());



		trace_rcu_dyntick("Error on exit: not idle task",

CRA Git | Maintained and supported by SUSTech CRA and CCSE