Commit 11d579ee authored Jun 28, 2008 by Wolfram Sang Committed by Grant Likely Jul 22, 2008

powerpc/mpc5200: Fix wrong 'no interrupt' handling in of_i2c



If an I2C device node does not specify an interrupt, the .irq member of the
board_info struct was set to -1. This caused crashes on following
irq_dispose_mappings. Leave it NO_IRQ as returned from irq_of_parse_and_map.
(Suggesting -1 as 'i2c-no-irq' used to be a bug in linux/i2c.h.)

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Acked-by: Sean MacLennan <smaclennan@pikatech.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

parent e89970aa

drivers/of/of_i2c.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -91,8 +91,6 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
		}

		info.irq = irq_of_parse_and_map(node, 0);
		if (info.irq == NO_IRQ)
		info.irq = -1;

		if (of_find_i2c_driver(node, &info) < 0) {
		irq_dispose_mapping(info.irq);

Admin message