Commit 11b407a7 authored Feb 18, 2020 by Huang Rui Committed by Alex Deucher Apr 28, 2020

drm/amdgpu: fix the wrong logic checking when secure buffer is created (v3)



While the current amdgpu doesn't support TMZ, it will return the error if user
mode would like to allocate secure buffer.

v2: we didn't need this checking anymore.
v3: only print message once time.

Signed-off-by: Huang Rui <ray.huang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Acked-by: Nirmoy Das <Nirmoy.Das@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 0bb5d5b0

drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -242,8 +242,8 @@ int amdgpu_gem_create_ioctl(struct drm_device dev, void data,
		if (args->in.domains & ~AMDGPU_GEM_DOMAIN_MASK)
		return -EINVAL;

		if (amdgpu_is_tmz(adev) && (flags & AMDGPU_GEM_CREATE_ENCRYPTED)) {
		DRM_ERROR("Cannot allocate secure buffer since TMZ is disabled\n");
		if (!amdgpu_is_tmz(adev) && (flags & AMDGPU_GEM_CREATE_ENCRYPTED)) {
		DRM_NOTE_ONCE("Cannot allocate secure buffer since TMZ is disabled\n");
		return -EINVAL;
		}

Admin message