Commit 11a223ae authored Mar 02, 2006 by Pete Zaitcev Committed by Greg Kroah-Hartman Mar 20, 2006

[PATCH] USB: ub 03 drop stall clearing

Matt mentioned that a very old ZIP-100 actually does need this, but I am
yet to see anyone who actually has one still working and uses ub with it.
He/she must be a retrocomputing geek, who can easily bias it to usb-storage
with libusual, if needed. Meanwhile, common folks have trouble with poorly
designed USB keys and some el-cheapo European music players. I think we
better drop this for now.

Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 952ba222

drivers/block/ub.c

+1 −12

Original line number	Diff line number	Diff line
		@@ -2270,19 +2270,8 @@ static int ub_probe(struct usb_interface *intf,

		nluns = 1;
		for (i = 0; i < 3; i++) {
		if ((rc = ub_sync_getmaxlun(sc)) < 0) {
		/*
		* This segment is taken from usb-storage. They say
		* that ZIP-100 needs this, but my own ZIP-100 works
		* fine without this.
		* Still, it does not seem to hurt anything.
		*/
		if (rc == -EPIPE) {
		ub_probe_clear_stall(sc, sc->recv_bulk_pipe);
		ub_probe_clear_stall(sc, sc->send_bulk_pipe);
		}
		if ((rc = ub_sync_getmaxlun(sc)) < 0)
		break;
		}
		if (rc != 0) {
		nluns = rc;
		break;

Admin message