Commit 119d6f6a authored Nov 30, 2015 by Sasha Levin Committed by Ingo Molnar Dec 04, 2015

sched/core: Remove false-positive warning from wake_up_process()



Because wakeups can (fundamentally) be late, a task might not be in
the expected state. Therefore testing against a task's state is racy,
and can yield false positives.

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: oleg@redhat.com
Fixes: 9067ac85 ("wake_up_process() should be never used to wakeup a TASK_STOPPED/TRACED task")
Link: http://lkml.kernel.org/r/1448933660-23082-1-git-send-email-sasha.levin@oracle.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 68985633

kernel/sched/core.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2039,7 +2039,6 @@ out:
		*/
		int wake_up_process(struct task_struct *p)
		{
		WARN_ON(task_is_stopped_or_traced(p));
		return try_to_wake_up(p, TASK_NORMAL, 0);
		}
		EXPORT_SYMBOL(wake_up_process);

Admin message