Commit 117e3b7f authored Apr 22, 2018 by Steve French Committed by Steve French Apr 24, 2018

CIFS: set *resp_buf_type to NO_BUFFER on error



Dan Carpenter had pointed this out a while ago, but the code around
this had changed so wasn't causing any problems since that field
was not used in this error path.

Still, it is cleaner to always initialize this field, so changing
the error path to set it.

Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
CC: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <smfrench@gmail.com>

parent 6d08b06e

fs/cifs/transport.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -834,8 +834,11 @@ SendReceive2(const unsigned int xid, struct cifs_ses *ses,
		if (n_vec + 1 > CIFS_MAX_IOV_SIZE) {
		new_iov = kmalloc(sizeof(struct kvec) * (n_vec + 1),
		GFP_KERNEL);
		if (!new_iov)
		if (!new_iov) {
		/* otherwise cifs_send_recv below sets resp_buf_type */
		*resp_buf_type = CIFS_NO_BUFFER;
		return -ENOMEM;
		}
		} else
		new_iov = s_iov;

Admin message