Unverified Commit 117858bd authored May 23, 2020 by Dinghao Liu Committed by Mark Brown May 28, 2020

spi: tegra20-sflash: Fix runtime PM imbalance on error



pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20200523124758.28604-1-dinghao.liu@zju.edu.cn


Signed-off-by: Mark Brown <broonie@kernel.org>

parent faedcc17

drivers/spi/spi-tegra20-sflash.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -491,6 +491,7 @@ static int tegra_sflash_probe(struct platform_device *pdev)
	ret = pm_runtime_get_sync(&pdev->dev);		ret = pm_runtime_get_sync(&pdev->dev);
	if (ret < 0) {		if (ret < 0) {
	dev_err(&pdev->dev, "pm runtime get failed, e = %d\n", ret);		dev_err(&pdev->dev, "pm runtime get failed, e = %d\n", ret);
			pm_runtime_put_noidle(&pdev->dev);
	goto exit_pm_disable;		goto exit_pm_disable;
	}		}

Admin message