Commit 116bfa96 authored Jan 29, 2019 by Valdis Kletnieks Committed by Daniel Borkmann Jan 31, 2019

bpf: fix missing prototype warnings



Compiling with W=1 generates warnings:

  CC      kernel/bpf/core.o
kernel/bpf/core.c:721:12: warning: no previous prototype for ?bpf_jit_alloc_exec_limit? [-Wmissing-prototypes]
  721 | u64 __weak bpf_jit_alloc_exec_limit(void)
      |            ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/bpf/core.c:757:14: warning: no previous prototype for ?bpf_jit_alloc_exec? [-Wmissing-prototypes]
  757 | void *__weak bpf_jit_alloc_exec(unsigned long size)
      |              ^~~~~~~~~~~~~~~~~~
kernel/bpf/core.c:762:13: warning: no previous prototype for ?bpf_jit_free_exec? [-Wmissing-prototypes]
  762 | void __weak bpf_jit_free_exec(void *addr)
      |             ^~~~~~~~~~~~~~~~~

All three are weak functions that archs can override, provide
proper prototypes for when a new arch provides their own.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Acked-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

parent de1da68d

include/linux/filter.h

+3 −1

Original line number	Diff line number	Diff line
		@@ -880,7 +880,9 @@ bpf_jit_binary_alloc(unsigned int proglen, u8 **image_ptr,
		unsigned int alignment,
		bpf_jit_fill_hole_t bpf_fill_ill_insns);
		void bpf_jit_binary_free(struct bpf_binary_header *hdr);

		u64 bpf_jit_alloc_exec_limit(void);
		void *bpf_jit_alloc_exec(unsigned long size);
		void bpf_jit_free_exec(void *addr);
		void bpf_jit_free(struct bpf_prog *fp);

		int bpf_jit_get_func_addr(const struct bpf_prog *prog,

Admin message