Commit 115e8a28 authored Sep 21, 2009 by Ingo Molnar

modules, tracing: Remove stale struct marker signature from module_layout()



Linus reported this new build warning:

  kernel/module.c:2951: warning: ?struct marker? declared inside parameter list
  kernel/module.c:2951: warning: its scope is only this definition or declaration, which is probably not what you want

Caused by:

  fc537766: tracing: Remove markers

module_layout() is an artificial symbol with 'significant' symbols
listed in its argument list so that it gets a proper argument types
signature that modversions can pick up to decide whether a
module is version-compatible or not. If these dont match then we
wont even look at a module.

Remove the stale marker symbol.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
LKML-Reference: <alpine.LFD.2.01.0909210908020.4950@localhost.localdomain>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 99610793

kernel/module.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2947,7 +2947,6 @@ void module_layout(struct module *mod,
		struct modversion_info *ver,
		struct kernel_param *kp,
		struct kernel_symbol *ks,
		struct marker *marker,
		struct tracepoint *tp)
		{
		}

Admin message