Commit 1158f762 authored Feb 04, 2011 by Pavel Emelyanov Committed by David S. Miller Feb 04, 2011

bridge: Don't put partly initialized fdb into hash



The fdb_create() puts a new fdb into hash with only addr set. This is
not good, since there are callers, that search the hash w/o the lock
and access all the other its fields.

Applies to current netdev tree.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f60ac8e7

net/bridge/br_fdb.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -328,12 +328,12 @@ static struct net_bridge_fdb_entry fdb_create(struct hlist_head head,
		fdb = kmem_cache_alloc(br_fdb_cache, GFP_ATOMIC);
		if (fdb) {
		memcpy(fdb->addr.addr, addr, ETH_ALEN);
		hlist_add_head_rcu(&fdb->hlist, head);

		fdb->dst = source;
		fdb->is_local = is_local;
		fdb->is_static = is_local;
		fdb->ageing_timer = jiffies;

		hlist_add_head_rcu(&fdb->hlist, head);
		}
		return fdb;
		}

Admin message