Commit 11331125 authored by Chris Wilson's avatar Chris Wilson
Browse files

drm/i915: Mark up address spaces that may need to allocate 



Since we cannot allocate underneath the vm->mutex (it is used in the
direct-reclaim paths), we need to shift the allocations off into a
mutexless worker with fence recursion prevention. To know when we need
this protection, we mark up the address spaces that do allocate before
insertion. In the future, we may wish to extend the async bind scheme to
more than just allocations.

v2: s/vm->bind_alloc/vm->bind_async_flags/

Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191004134015.13204-3-chris@chris-wilson.co.uk
parent 5e053450

drivers/gpu/drm/i915/i915_gem_gtt.c

+3 −0
Original line number Diff line number Diff line
@@ -1502,6 +1502,7 @@ static struct i915_ppgtt *gen8_ppgtt_create(struct drm_i915_private *i915) 
			goto err_free_pd;

	}



	ppgtt->vm.bind_async_flags = I915_VMA_LOCAL_BIND;

	ppgtt->vm.insert_entries = gen8_ppgtt_insert;

	ppgtt->vm.allocate_va_range = gen8_ppgtt_alloc;

	ppgtt->vm.clear_range = gen8_ppgtt_clear;
@@ -1950,6 +1951,7 @@ static struct i915_ppgtt *gen6_ppgtt_create(struct drm_i915_private *i915) 
	ppgtt_init(&ppgtt->base, &i915->gt);

	ppgtt->base.vm.top = 1;



	ppgtt->base.vm.bind_async_flags = I915_VMA_LOCAL_BIND;

	ppgtt->base.vm.allocate_va_range = gen6_alloc_va_range;

	ppgtt->base.vm.clear_range = gen6_ppgtt_clear_range;

	ppgtt->base.vm.insert_entries = gen6_ppgtt_insert_entries;
@@ -2581,6 +2583,7 @@ static int init_aliasing_ppgtt(struct i915_ggtt *ggtt) 
		goto err_ppgtt;



	ggtt->alias = ppgtt;

	ggtt->vm.bind_async_flags |= ppgtt->vm.bind_async_flags;



	GEM_BUG_ON(ggtt->vm.vma_ops.bind_vma != ggtt_bind_vma);

	ggtt->vm.vma_ops.bind_vma = aliasing_gtt_bind_vma;

drivers/gpu/drm/i915/i915_gem_gtt.h

+2 −0
Original line number Diff line number Diff line
@@ -305,6 +305,8 @@ struct i915_address_space { 
	u64 total;		/* size addr space maps (ex. 2GB for ggtt) */

	u64 reserved;		/* size addr space reserved */



	unsigned int bind_async_flags;



	bool closed;



	struct mutex mutex; /* protects vma and our lists */

CRA Git | Maintained and supported by SUSTech CRA and CCSE