mfd: htc-i2cpld: Make it explicitly non-modular (11165223) · Commits · 戴 / test

The Kconfig for this option is currently: config HTC_I2CPLD bool "HTC I2C PLD chip support" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments. Signed-off-by:

Paul Gortmaker <paul.gortmaker@windriver.com> Acked-by:

Linus Walleij <linus.walleij@linaro.org> Signed-off-by:

Lee Jones <lee.jones@linaro.org>

drivers/mfd/htc-i2cpld.c

+1 −17

Original line number	Diff line number	Diff line
		@@ -27,7 +27,6 @@

		#include <linux/kernel.h>
		#include <linux/init.h>
		#include <linux/module.h>
		#include <linux/interrupt.h>
		#include <linux/platform_device.h>
		#include <linux/i2c.h>
		@@ -614,8 +613,6 @@ static const struct i2c_device_id htcpld_chip_id[] = {
		{ "htcpld-chip", 0 },
		{ }
		};
		MODULE_DEVICE_TABLE(i2c, htcpld_chip_id);


		static struct i2c_driver htcpld_chip_driver = {
		.driver = {
		@@ -643,17 +640,4 @@ static int __init htcpld_core_init(void)
		/* Probe for our chips */
		return platform_driver_probe(&htcpld_core_driver, htcpld_core_probe);
		}

		static void __exit htcpld_core_exit(void)
		{
		i2c_del_driver(&htcpld_chip_driver);
		platform_driver_unregister(&htcpld_core_driver);
		}

		module_init(htcpld_core_init);
		module_exit(htcpld_core_exit);

		MODULE_AUTHOR("Cory Maccarrone <darkstar6262@gmail.com>");
		MODULE_DESCRIPTION("I2C HTC PLD Driver");
		MODULE_LICENSE("GPL");

		device_initcall(htcpld_core_init);

Admin message