Commit 10f39758 authored by Bernard Zhao's avatar Bernard Zhao Committed by Alex Deucher
Browse files

drm/amdgpu: cleanup coding style in amdkfd a bit



Make the code a bit more readable by using a common
error handling pattern.

Signed-off-by: default avatarBernard Zhao <bernard@vivo.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com&gt;.>
Reviewed-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent e05185b3
Loading
Loading
Loading
Loading
+9 −11
Original line number Diff line number Diff line
@@ -660,15 +660,15 @@ static int reserve_bo_and_vm(struct kgd_mem *mem,

	ret = ttm_eu_reserve_buffers(&ctx->ticket, &ctx->list,
				     false, &ctx->duplicates);
	if (!ret)
		ctx->reserved = true;
	else {
		pr_err("Failed to reserve buffers in ttm\n");
	if (ret) {
		pr_err("Failed to reserve buffers in ttm.\n");
		kfree(ctx->vm_pd);
		ctx->vm_pd = NULL;
		return ret;
	}

	return ret;
	ctx->reserved = true;
	return 0;
}

/**
@@ -733,17 +733,15 @@ static int reserve_bo_and_cond_vms(struct kgd_mem *mem,

	ret = ttm_eu_reserve_buffers(&ctx->ticket, &ctx->list,
				     false, &ctx->duplicates);
	if (!ret)
		ctx->reserved = true;
	else
		pr_err("Failed to reserve buffers in ttm.\n");

	if (ret) {
		pr_err("Failed to reserve buffers in ttm.\n");
		kfree(ctx->vm_pd);
		ctx->vm_pd = NULL;
		return ret;
	}

	return ret;
	ctx->reserved = true;
	return 0;
}

/**