Commit 10d2c46f authored Sep 22, 2005 by Nick Wilson Committed by Linus Torvalds Sep 22, 2005

[PATCH] NFS: fix client oops when debugging is on



nfs_readpage_release() causes an oops while accessing a file with NFS
debugging turned on (echo 32767 > /proc/sys/sunrpc/nfs_debug) and a kernel
built with CONFIG_DEBUG_SLAB.

This patch moves the debugging statement above nfs_release_request() to
avoid accessing freed memory.

Signed-off-by: Nick Wilson <njw@osdl.org>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent f7b3a435

fs/nfs/read.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -184,14 +184,13 @@ static void nfs_readpage_release(struct nfs_page *req)
		{
		unlock_page(req->wb_page);

		nfs_clear_request(req);
		nfs_release_request(req);

		dprintk("NFS: read done (%s/%Ld %d@%Ld)\n",
		req->wb_context->dentry->d_inode->i_sb->s_id,
		(long long)NFS_FILEID(req->wb_context->dentry->d_inode),
		req->wb_bytes,
		(long long)req_offset(req));
		nfs_clear_request(req);
		nfs_release_request(req);
		}

		/*

Admin message