Commit 10cc2b50 authored Mar 05, 2010 by Herbert Xu Committed by David S. Miller Mar 07, 2010

bridge: Fix RCU race in br_multicast_stop



Thanks to Paul McKenny for pointing out that it is incorrect to use
synchronize_rcu_bh to ensure that pending callbacks have completed.
Instead we should use rcu_barrier_bh.

Reported-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 49f5fcfd

net/bridge/br_multicast.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1135,7 +1135,7 @@ void br_multicast_stop(struct net_bridge *br)

		if (mdb->old) {
		spin_unlock_bh(&br->multicast_lock);
		synchronize_rcu_bh();
		rcu_barrier_bh();
		spin_lock_bh(&br->multicast_lock);
		WARN_ON(mdb->old);
		}

Admin message