time: remove obsolete CLOCK_TICK_ADJUST (10a398d0) · Commits · 戴 / test

The first version of the ntp_interval/tick_length inconsistent usage patch was recently merged as http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=bbe4d18ac2e058c56adb0cd71f49d9ed3216a405 While the fix did greatly improve the situation, it was correctly pointed out by Roman that it does have a small bug: If the users change clocksources after the system has been running and NTP has made corrections, the correctoins made against the old clocksource will be applied against the new clocksource, causing error. The second attempt, which corrects the issue in the NTP_INTERVAL_LENGTH definition has also made it up-stream as commit http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e13a2e61dd5152f5499d2003470acf9c838eab84 Roman has correctly pointed out that CLOCK_TICK_ADJUST is calculated based on the PIT's frequency, and isn't really relevant to non-PIT driven clocksources (that is, clocksources other then jiffies and pit). This patch reverts both of those changes, and simply removes CLOCK_TICK_ADJUST. This does remove the granularity error correction for users of PIT and Jiffies clocksource users, but the granularity error but for the majority of users, it should be within the 500ppm range NTP can accommodate for. For systems that have granularity errors greater then 500ppm, the "ntp_tick_adj=" boot option can be used to compensate. [johnstul@us.ibm.com: provided changelog] [mattilinnanvuori@yahoo.com: maek ntp_tick_adj static] Signed-off-by:

Roman Zippel <zippel@linux-m68k.org> Acked-by:

john stultz <johnstul@us.ibm.com> Signed-off-by:

Matti Linnanvuori <mattilinnanvuori@yahoo.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Cc: mingo@elte.hu Signed-off-by:

Thomas Gleixner <tglx@linutronix.de>

include/linux/timex.h

+1 −8

Original line number	Diff line number	Diff line
		@@ -232,14 +232,7 @@ static inline int ntp_synced(void)
		#else
		#define NTP_INTERVAL_FREQ (HZ)
		#endif

		#define CLOCK_TICK_OVERFLOW (LATCH * HZ - CLOCK_TICK_RATE)
		#define CLOCK_TICK_ADJUST (((s64)CLOCK_TICK_OVERFLOW * NSEC_PER_SEC) / \
		(s64)CLOCK_TICK_RATE)

		/* Because using NSEC_PER_SEC would be too easy */
		#define NTP_INTERVAL_LENGTH ((((s64)TICK_USEC * NSEC_PER_USEC * USER_HZ) + \
		CLOCK_TICK_ADJUST) / NTP_INTERVAL_FREQ)
		#define NTP_INTERVAL_LENGTH (NSEC_PER_SEC/NTP_INTERVAL_FREQ)

		/* Returns how long ticks are at present, in ns / 2^(SHIFT_SCALE-10). */
		extern u64 current_tick_length(void);

kernel/time/ntp.c

+10 −1

Original line number	Diff line number	Diff line
		@@ -42,12 +42,13 @@ long time_esterror = NTP_PHASE_LIMIT; /* estimated error (us) */
		long time_freq; /* frequency offset (scaled ppm)*/
		static long time_reftime; /* time at last adjustment (s) */
		long time_adjust;
		static long ntp_tick_adj;

		static void ntp_update_frequency(void)
		{
		u64 second_length = (u64)(tick_usec * NSEC_PER_USEC * USER_HZ)
		<< TICK_LENGTH_SHIFT;
		second_length += (s64)CLOCK_TICK_ADJUST << TICK_LENGTH_SHIFT;
		second_length += (s64)ntp_tick_adj << TICK_LENGTH_SHIFT;
		second_length += (s64)time_freq << (TICK_LENGTH_SHIFT - SHIFT_NSEC);

		tick_length_base = second_length;
		@@ -402,3 +403,11 @@ leave: if ((time_status & (STA_UNSYNC\|STA_CLOCKERR)) != 0)
		notify_cmos_timer();
		return(result);
		}

		static int __init ntp_tick_adj_setup(char *str)
		{
		ntp_tick_adj = simple_strtol(str, NULL, 0);
		return 1;
		}

		__setup("ntp_tick_adj=", ntp_tick_adj_setup);

kernel/time/timekeeping.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -187,8 +187,7 @@ static void change_clocksource(void)

		clock->error = 0;
		clock->xtime_nsec = 0;
		clocksource_calculate_interval(clock,
		(unsigned long)(current_tick_length()>>TICK_LENGTH_SHIFT));
		clocksource_calculate_interval(clock, NTP_INTERVAL_LENGTH);

		tick_clock_notify();

		@@ -245,8 +244,7 @@ void __init timekeeping_init(void)
		ntp_clear();

		clock = clocksource_get_next();
		clocksource_calculate_interval(clock,
		(unsigned long)(current_tick_length()>>TICK_LENGTH_SHIFT));
		clocksource_calculate_interval(clock, NTP_INTERVAL_LENGTH);
		clock->cycle_last = clocksource_read(clock);

		xtime.tv_sec = sec;

Admin message