Commit 109dae8d authored by Dmitry Eremin's avatar Dmitry Eremin Committed by Greg Kroah-Hartman
Browse files

staging/lustre/lnet: fix potential null pointer dereference in kiblnd_rejected 



Null pointer 'cp' that comes from line 2544 may be dereferenced
at line 2618.
found by Klocwork Insight tool

Signed-off-by: default avatarDmitry Eremin <dmitry.eremin@intel.com>
Reviewed-on: http://review.whamcloud.com/9386
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629


Reviewed-by: default avatarJohn L. Hammond <john.hammond@intel.com>
Reviewed-by: default avatarIsaac Huang <he.huang@intel.com>
Signed-off-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1ae2bdb2

drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c

+6 −2
Original line number Diff line number Diff line
@@ -2609,13 +2609,17 @@ kiblnd_rejected (kib_conn_t *conn, int reason, void *priv, int priv_nob) 


			case IBLND_REJECT_MSG_QUEUE_SIZE:

				CERROR("%s rejected: incompatible message queue depth %d, %d\n",

				       libcfs_nid2str(peer->ibp_nid), cp->ibcp_queue_depth,

				       libcfs_nid2str(peer->ibp_nid),

				       cp != NULL ? cp->ibcp_queue_depth :

				       IBLND_MSG_QUEUE_SIZE(rej->ibr_version),

				       IBLND_MSG_QUEUE_SIZE(conn->ibc_version));

				break;



			case IBLND_REJECT_RDMA_FRAGS:

				CERROR("%s rejected: incompatible # of RDMA fragments %d, %d\n",

				       libcfs_nid2str(peer->ibp_nid), cp->ibcp_max_frags,

				       libcfs_nid2str(peer->ibp_nid),

				       cp != NULL ? cp->ibcp_max_frags :

				       IBLND_RDMA_FRAGS(rej->ibr_version),

				       IBLND_RDMA_FRAGS(conn->ibc_version));

				break;

CRA Git | Maintained and supported by SUSTech CRA and CCSE