Commit 108f4664 authored Sep 26, 2020 by Tobias Jordan Committed by Pavel Machek Sep 30, 2020

leds: tlc591xx: fix leak of device node iterator



In one of the error paths of the for_each_child_of_node loop in
tlc591xx_probe, add missing call to of_node_put.

Fixes: 1ab4531a ("leds: tlc591xx: simplify driver by using the managed led API")

Signed-off-by: Tobias Jordan <kernel@cdqe.de>
Reviewed-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>

parent 564ead12

drivers/leds/leds-tlc591xx.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -205,11 +205,13 @@ tlc591xx_probe(struct i2c_client *client,
		led->ldev.max_brightness = TLC591XX_MAX_BRIGHTNESS;
		err = devm_led_classdev_register_ext(dev, &led->ldev,
		&init_data);
		if (err < 0)
		if (err < 0) {
		of_node_put(child);
		return dev_err_probe(dev, err,
		"couldn't register LED %s\n",
		led->ldev.name);
		}
		}
		return 0;
		}

Admin message