Commit 10853a03 authored by Minchan Kim's avatar Minchan Kim Committed by Linus Torvalds
Browse files

mm: move lazily freed pages to inactive list 



MADV_FREE is a hint that it's okay to discard pages if there is memory
pressure and we use reclaimers(ie, kswapd and direct reclaim) to free
them so there is no value keeping them in the active anonymous LRU so
this patch moves them to inactive LRU list's head.

This means that MADV_FREE-ed pages which were living on the inactive
list are reclaimed first because they are more likely to be cold rather
than recently active pages.

An arguable issue for the approach would be whether we should put the
page to the head or tail of the inactive list.  I chose head because the
kernel cannot make sure it's really cold or warm for every MADV_FREE
usecase but at least we know it's not *hot*, so landing of inactive head
would be a comprimise for various usecases.

This fixes suboptimal behavior of MADV_FREE when pages living on the
active list will sit there for a long time even under memory pressure
while the inactive list is reclaimed heavily.  This basically breaks the
whole purpose of using MADV_FREE to help the system to free memory which
is might not be used.

Signed-off-by: default avatarMinchan Kim <minchan@kernel.org>
Acked-by: default avatarHugh Dickins <hughd@google.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Rik van Riel <riel@redhat.com>
Cc: Shaohua Li <shli@kernel.org>
Cc: "James E.J. Bottomley" <jejb@parisc-linux.org>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: <yalin.wang2010@gmail.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Chris Zankel <chris@zankel.net>
Cc: Daniel Micay <danielmicay@gmail.com>
Cc: Darrick J. Wong <darrick.wong@oracle.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Helge Deller <deller@gmx.de>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Jason Evans <je@fb.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Kirill A. Shutemov <kirill@shutemov.name>
Cc: Matt Turner <mattst88@gmail.com>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: Mika Penttil <mika.penttila@nextfour.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Roland Dreier <roland@kernel.org>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 64b42bc1

include/linux/swap.h

+1 −0
Original line number Diff line number Diff line
@@ -307,6 +307,7 @@ extern void lru_add_drain_cpu(int cpu); 
extern void lru_add_drain_all(void);

extern void rotate_reclaimable_page(struct page *page);

extern void deactivate_file_page(struct page *page);

extern void deactivate_page(struct page *page);

extern void swap_setup(void);



extern void add_page_to_unevictable_list(struct page *page);

mm/madvise.c

+2 −0
Original line number Diff line number Diff line
@@ -368,6 +368,8 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, 
			ptent = pte_mkold(ptent);

			ptent = pte_mkclean(ptent);

			set_pte_at(mm, addr, pte, ptent);

			if (PageActive(page))

				deactivate_page(page);

			tlb_remove_tlb_entry(tlb, pte, addr);

		}

	}

mm/swap.c

+44 −0
Original line number Diff line number Diff line
@@ -45,6 +45,7 @@ int page_cluster; 
static DEFINE_PER_CPU(struct pagevec, lru_add_pvec);

static DEFINE_PER_CPU(struct pagevec, lru_rotate_pvecs);

static DEFINE_PER_CPU(struct pagevec, lru_deactivate_file_pvecs);

static DEFINE_PER_CPU(struct pagevec, lru_deactivate_pvecs);



/*

 * This path almost never happens for VM activity - pages are normally
@@ -554,6 +555,24 @@ static void lru_deactivate_file_fn(struct page *page, struct lruvec *lruvec, 
	update_page_reclaim_stat(lruvec, file, 0);

}





static void lru_deactivate_fn(struct page *page, struct lruvec *lruvec,

			    void *arg)

{

	if (PageLRU(page) && PageActive(page) && !PageUnevictable(page)) {

		int file = page_is_file_cache(page);

		int lru = page_lru_base_type(page);



		del_page_from_lru_list(page, lruvec, lru + LRU_ACTIVE);

		ClearPageActive(page);

		ClearPageReferenced(page);

		add_page_to_lru_list(page, lruvec, lru);



		__count_vm_event(PGDEACTIVATE);

		update_page_reclaim_stat(lruvec, file, 0);

	}

}



/*

 * Drain pages out of the cpu's pagevecs.

 * Either "cpu" is the current CPU, and preemption has already been
@@ -580,6 +599,10 @@ void lru_add_drain_cpu(int cpu) 
	if (pagevec_count(pvec))

		pagevec_lru_move_fn(pvec, lru_deactivate_file_fn, NULL);



	pvec = &per_cpu(lru_deactivate_pvecs, cpu);

	if (pagevec_count(pvec))

		pagevec_lru_move_fn(pvec, lru_deactivate_fn, NULL);



	activate_page_drain(cpu);

}
@@ -609,6 +632,26 @@ void deactivate_file_page(struct page *page) 
	}

}



/**

 * deactivate_page - deactivate a page

 * @page: page to deactivate

 *

 * deactivate_page() moves @page to the inactive list if @page was on the active

 * list and was not an unevictable page.  This is done to accelerate the reclaim

 * of @page.

 */

void deactivate_page(struct page *page)

{

	if (PageLRU(page) && PageActive(page) && !PageUnevictable(page)) {

		struct pagevec *pvec = &get_cpu_var(lru_deactivate_pvecs);



		page_cache_get(page);

		if (!pagevec_add(pvec, page))

			pagevec_lru_move_fn(pvec, lru_deactivate_fn, NULL);

		put_cpu_var(lru_deactivate_pvecs);

	}

}



void lru_add_drain(void)

{

	lru_add_drain_cpu(get_cpu());
@@ -638,6 +681,7 @@ void lru_add_drain_all(void) 
		if (pagevec_count(&per_cpu(lru_add_pvec, cpu)) ||

		    pagevec_count(&per_cpu(lru_rotate_pvecs, cpu)) ||

		    pagevec_count(&per_cpu(lru_deactivate_file_pvecs, cpu)) ||

		    pagevec_count(&per_cpu(lru_deactivate_pvecs, cpu)) ||

		    need_activate_page_drain(cpu)) {

			INIT_WORK(work, lru_add_drain_per_cpu);

			schedule_work_on(cpu, work);

CRA Git | Maintained and supported by SUSTech CRA and CCSE