Commit 107ce6d2 authored by Eric Sesterhenn's avatar Eric Sesterhenn Committed by Jeff Garzik
Browse files

[PATCH] Remove unnecessary check in drivers/net/depca.c 



This was spotted by coverity (cid #793).  All callers dereference dev
before calling this functions, and we dereference it earlier in the
function, when initializing lp.

Signed-off-by: default avatarEric Sesterhenn <snakebyte@gmx.de>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent a189317f

drivers/net/depca.c

+13 −15
Original line number Diff line number Diff line
@@ -1252,7 +1252,6 @@ static void set_multicast_list(struct net_device *dev) 
	struct depca_private *lp = (struct depca_private *) dev->priv;

	u_long ioaddr = dev->base_addr;



	if (dev) {

	netif_stop_queue(dev);

	while (lp->tx_old != lp->tx_new);	/* Wait for the ring to empty */
@@ -1270,7 +1269,6 @@ static void set_multicast_list(struct net_device *dev) 
	InitRestartDepca(dev);	/* Resume normal operation. */

	netif_start_queue(dev);	/* Unlock the TX ring */

}

}



/*

** Calculate the hash code and update the logical address filter

CRA Git | Maintained and supported by SUSTech CRA and CCSE