Commit 106a307f authored Jul 24, 2020 by Marco Elver Committed by Paul E. McKenney Aug 24, 2020

kcsan: Skew delay to be longer for certain access types



For compound instrumentation and assert accesses, skew the watchpoint
delay to be longer if randomized. This is useful to improve race
detection for such accesses.

For compound accesses we should increase the delay as we've aggregated
both read and write instrumentation. By giving up 1 call into the
runtime, we're less likely to set up a watchpoint and thus less likely
to detect a race. We can balance this by increasing the watchpoint
delay.

For assert accesses, we know these are of increased interest, and we
wish to increase our chances of detecting races for such checks.

Note that, kcsan_udelay_{task,interrupt} define the upper bound delays.
When randomized, delays are uniformly distributed between [0, delay].
Skewing the delay does not break this promise as long as the defined
upper bounds are still adhered to. The current skew results in delays
uniformly distributed between [delay/2, delay].

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>

parent a81b3759

kernel/kcsan/core.c

+7 −3

Original line number	Diff line number	Diff line
		@@ -283,11 +283,15 @@ static __always_inline bool kcsan_is_enabled(void)
		return READ_ONCE(kcsan_enabled) && get_ctx()->disable_count == 0;
		}

		static inline unsigned int get_delay(void)
		static inline unsigned int get_delay(int type)
		{
		unsigned int delay = in_task() ? kcsan_udelay_task : kcsan_udelay_interrupt;
		/* For certain access types, skew the random delay to be longer. */
		unsigned int skew_delay_order =
		(type & (KCSAN_ACCESS_COMPOUND \| KCSAN_ACCESS_ASSERT)) ? 1 : 0;

		return delay - (IS_ENABLED(CONFIG_KCSAN_DELAY_RANDOMIZE) ?
		prandom_u32_max(delay) :
		prandom_u32_max(delay >> skew_delay_order) :
		0);
		}

		@@ -470,7 +474,7 @@ kcsan_setup_watchpoint(const volatile void *ptr, size_t size, int type)
		* Delay this thread, to increase probability of observing a racy
		* conflicting access.
		*/
		udelay(get_delay());
		udelay(get_delay(type));

		/*
		* Re-read value, and check if it is as expected; if not, we infer a

Admin message