Commit 1059ecfa authored by Ryo Tsutsui's avatar Ryo Tsutsui Committed by Mark Brown
Browse files

ASoC: dapm: Only clear paths we've walked 



When clearing the walked flags there is no need to clear all paths, we
only need to clear the paths we actually walked. This means we can split
dapm_clear_walk() into input and output versions and rather than going
through all DAPM paths we can recurse down the path until we encounter
paths we have not yet walked.

This reduces the number of operations we need to perform and improves
cache locality.

[Pulled out of the vendor tree that the patch was originally generated
for by me, any bugs were introduced in that process -- broonie]

Signed-off-by: default avatarRyo Tsutsui <Ryo.Tsutsui@wolfsonmicro.com>
Acked-by: default avatarLiam Girdwood <liam.r.girdwood@linux.intel.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 0e669246

sound/soc/soc-dapm.c

+35 −12
Original line number Diff line number Diff line
@@ -707,13 +707,32 @@ static int dapm_new_pga(struct snd_soc_dapm_widget *w) 
}



/* reset 'walked' bit for each dapm path */

static inline void dapm_clear_walk(struct snd_soc_dapm_context *dapm)

static void dapm_clear_walk_output(struct snd_soc_dapm_context *dapm,

				   struct list_head *sink)

{

	struct snd_soc_dapm_path *p;



	list_for_each_entry(p, &dapm->card->paths, list)

	list_for_each_entry(p, sink, list_source) {

		if (p->walked) {

			p->walked = 0;

			dapm_clear_walk_output(dapm, &p->sink->sinks);

		}

	}

}



static void dapm_clear_walk_input(struct snd_soc_dapm_context *dapm,

				  struct list_head *source)

{

	struct snd_soc_dapm_path *p;



	list_for_each_entry(p, source, list_sink) {

		if (p->walked) {

			p->walked = 0;

			dapm_clear_walk_input(dapm, &p->source->sources);

		}

	}

}





/* We implement power down on suspend by checking the power state of

 * the ALSA card - when we are suspending the ALSA state for the card
@@ -983,13 +1002,17 @@ int snd_soc_dapm_dai_get_connected_widgets(struct snd_soc_dai *dai, int stream, 
	mutex_lock_nested(&card->dapm_mutex, SND_SOC_DAPM_CLASS_RUNTIME);

	dapm_reset(card);



	if (stream == SNDRV_PCM_STREAM_PLAYBACK)

	if (stream == SNDRV_PCM_STREAM_PLAYBACK) {

		paths = is_connected_output_ep(dai->playback_widget, list);

	else

		dapm_clear_walk_output(&card->dapm,

				       &dai->playback_widget->sinks);

	} else {

		paths = is_connected_input_ep(dai->capture_widget, list);

		dapm_clear_walk_input(&card->dapm,

				      &dai->capture_widget->sources);

	}



	trace_snd_soc_dapm_connected(paths, stream);

	dapm_clear_walk(&card->dapm);

	mutex_unlock(&card->dapm_mutex);



	return paths;
@@ -1092,9 +1115,9 @@ static int dapm_generic_check_power(struct snd_soc_dapm_widget *w) 
	DAPM_UPDATE_STAT(w, power_checks);



	in = is_connected_input_ep(w, NULL);

	dapm_clear_walk(w->dapm);

	dapm_clear_walk_input(w->dapm, &w->sources);

	out = is_connected_output_ep(w, NULL);

	dapm_clear_walk(w->dapm);

	dapm_clear_walk_output(w->dapm, &w->sinks);

	return out != 0 && in != 0;

}
@@ -1117,7 +1140,7 @@ static int dapm_adc_check_power(struct snd_soc_dapm_widget *w) 


	if (w->active) {

		in = is_connected_input_ep(w, NULL);

		dapm_clear_walk(w->dapm);

		dapm_clear_walk_input(w->dapm, &w->sources);

		return in != 0;

	} else {

		return dapm_generic_check_power(w);
@@ -1133,7 +1156,7 @@ static int dapm_dac_check_power(struct snd_soc_dapm_widget *w) 


	if (w->active) {

		out = is_connected_output_ep(w, NULL);

		dapm_clear_walk(w->dapm);

		dapm_clear_walk_output(w->dapm, &w->sinks);

		return out != 0;

	} else {

		return dapm_generic_check_power(w);
@@ -1745,9 +1768,9 @@ static ssize_t dapm_widget_power_read_file(struct file *file, 
		return -ENOMEM;



	in = is_connected_input_ep(w, NULL);

	dapm_clear_walk(w->dapm);

	dapm_clear_walk_input(w->dapm, &w->sources);

	out = is_connected_output_ep(w, NULL);

	dapm_clear_walk(w->dapm);

	dapm_clear_walk_output(w->dapm, &w->sinks);



	ret = snprintf(buf, PAGE_SIZE, "%s: %s%s  in %d out %d",

		       w->name, w->power ? "On" : "Off",

CRA Git | Maintained and supported by SUSTech CRA and CCSE