Commit 105976f5 authored Feb 23, 2018 by Ming Lei Committed by Jens Axboe Feb 24, 2018

blk-mq: don't call io sched's .requeue_request when requeueing rq to ->dispatch



__blk_mq_requeue_request() covers two cases:

- one is that the requeued request is added to hctx->dispatch, such as
blk_mq_dispatch_rq_list()

- another case is that the request is requeued to io scheduler, such as
blk_mq_requeue_request().

We should call io sched's .requeue_request callback only for the 2nd
case.

Cc: Paolo Valente <paolo.valente@linaro.org>
Cc: Omar Sandoval <osandov@fb.com>
Fixes: bd166ef1 ("blk-mq-sched: add framework for MQ capable IO schedulers")
Cc: stable@vger.kernel.org
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
Acked-by: Paolo Valente <paolo.valente@linaro.org>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 0bd1ed48

block/blk-mq.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -712,7 +712,6 @@ static void __blk_mq_requeue_request(struct request *rq)

		trace_block_rq_requeue(q, rq);
		wbt_requeue(q->rq_wb, &rq->issue_stat);
		blk_mq_sched_requeue_request(rq);

		if (blk_mq_rq_state(rq) != MQ_RQ_IDLE) {
		blk_mq_rq_update_state(rq, MQ_RQ_IDLE);
		@@ -725,6 +724,9 @@ void blk_mq_requeue_request(struct request *rq, bool kick_requeue_list)
		{
		__blk_mq_requeue_request(rq);

		/* this request will be re-inserted to io scheduler queue */
		blk_mq_sched_requeue_request(rq);

		BUG_ON(blk_queued_rq(rq));
		blk_mq_add_to_requeue_list(rq, true, kick_requeue_list);
		}

Admin message