Commit 10452966 authored May 16, 2013 by Dan Carpenter Committed by Jiri Kosina May 29, 2013

pktcdvd: silence static checker warning



Static checkers complain about widening the binary "not" operations here
because sectors are u64 and "(pd)->settings.size" is unsigned int.
It unintentionally clears the high 32 bits of the sector.  This means
that the driver won't work for devices with over 2TB of space.  Since
this is a DVD drive, we're unlikely to reach that limit, but we may as
well silence the warning.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent f722406f

drivers/block/pktcdvd.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -83,7 +83,8 @@

		#define MAX_SPEED 0xffff

		#define ZONE(sector, pd) (((sector) + (pd)->offset) & ~((pd)->settings.size - 1))
		#define ZONE(sector, pd) (((sector) + (pd)->offset) & \
		~(sector_t)((pd)->settings.size - 1))

		static DEFINE_MUTEX(pktcdvd_mutex);
		static struct pktcdvd_device *pkt_devs[MAX_WRITERS];

Admin message