Commit 10340236 authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: designware: Rename dw_pcie_valid_config() to dw_pcie_valid_device() 



Rename dw_pcie_valid_config() to dw_pcie_valid_device() and use the result
directly as a boolean value instead of testing against 0.  No functional
change intended.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent bdf53098

drivers/pci/host/pcie-designware.c

+4 −4
Original line number Diff line number Diff line
@@ -760,8 +760,8 @@ static int dw_pcie_wr_other_conf(struct pcie_port *pp, struct pci_bus *bus, 
	return ret;

}



static int dw_pcie_valid_config(struct pcie_port *pp,

				struct pci_bus *bus, int dev)

static int dw_pcie_valid_device(struct pcie_port *pp, struct pci_bus *bus,

				int dev)

{

	/* If there is no link, then there is no device */

	if (bus->number != pp->root_bus_nr) {
@@ -781,7 +781,7 @@ static int dw_pcie_rd_conf(struct pci_bus *bus, u32 devfn, int where, 
{

	struct pcie_port *pp = bus->sysdata;



	if (dw_pcie_valid_config(pp, bus, PCI_SLOT(devfn)) == 0) {

	if (!dw_pcie_valid_device(pp, bus, PCI_SLOT(devfn))) {

		*val = 0xffffffff;

		return PCIBIOS_DEVICE_NOT_FOUND;

	}
@@ -797,7 +797,7 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn, 
{

	struct pcie_port *pp = bus->sysdata;



	if (dw_pcie_valid_config(pp, bus, PCI_SLOT(devfn)) == 0)

	if (!dw_pcie_valid_device(pp, bus, PCI_SLOT(devfn)))

		return PCIBIOS_DEVICE_NOT_FOUND;



	if (bus->number == pp->root_bus_nr)

CRA Git | Maintained and supported by SUSTech CRA and CCSE