Commit 1033be58 authored Jan 04, 2019 by Bartosz Golaszewski

gpiolib: fix line event timestamps for nested irqs



Nested interrupts run inside the calling thread's context and the top
half handler is never called which means that we never read the
timestamp.

This issue came up when trying to read line events from a gpiochip
using regmap_irq_chip for interrupts.

Fix it by reading the timestamp from the irq thread function if it's
still 0 by the time the second handler is called.

Fixes: d58f2bf2 ("gpio: Timestamp events in hardirq handler")
Cc: stable@vger.kernel.org
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

parent 2486e673

drivers/gpio/gpiolib.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -828,6 +828,13 @@ static irqreturn_t lineevent_irq_thread(int irq, void *p)
		/* Do not leak kernel stack to userspace */
		memset(&ge, 0, sizeof(ge));

		/*
		* We may be running from a nested threaded interrupt in which case
		* we didn't get the timestamp from lineevent_irq_handler().
		*/
		if (!le->timestamp)
		ge.timestamp = ktime_get_real_ns();
		else
		ge.timestamp = le->timestamp;

		if (le->eflags & GPIOEVENT_REQUEST_RISING_EDGE

Admin message