Commit 100a149f authored Jul 29, 2020 by Colin Ian King Committed by Greg Kroah-Hartman Jul 29, 2020

staging: rtl8723bs: remove redundant assignment to variable ret

The variable ret is being assigned an error return value that is never
read, the control passes to a return statement and ret is never referenced.
Remove the redundant assignment. Also remove an empty line.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200729100525.573500-1-colin.king@canonical.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7f921e92

drivers/staging/rtl8723bs/os_dep/osdep_service.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -146,10 +146,8 @@ int rtw_change_ifname(struct adapter padapter, const char ifname)
		rereg_priv->old_pnetdev = cur_pnetdev;

		pnetdev = rtw_init_netdev(padapter);
		if (!pnetdev) {
		ret = -1;
		if (!pnetdev)
		goto error;
		}

		SET_NETDEV_DEV(pnetdev, dvobj_to_dev(adapter_to_dvobj(padapter)));

		@@ -170,9 +168,7 @@ int rtw_change_ifname(struct adapter padapter, const char ifname)
		return 0;

		error:

		return -1;

		}

		void rtw_buf_free(u8 *buf, u32 buf_len)