Commit 0fec9557 authored Jan 17, 2017 by Tobias Klauser Committed by Thomas Gleixner Jan 18, 2017

cpu/hotplug: Remove unused but set variable in _cpu_down()



After the recent removal of the hotplug notifiers the variable 'hasdied' in
_cpu_down() is set but no longer read, leading to the following GCC warning
when building with 'make W=1':

  kernel/cpu.c:767:7: warning: variable ‘hasdied’ set but not used [-Wunused-but-set-variable]

Fix it by removing the variable.

Fixes: 530e9b76 ("cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions")
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: rt@linutronix.de
Link: http://lkml.kernel.org/r/20170117143501.20893-1-tklauser@distanz.ch


Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 4205e478

kernel/cpu.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -764,7 +764,6 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen,
		{
		struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu);
		int prev_state, ret = 0;
		bool hasdied = false;

		if (num_online_cpus() == 1)
		return -EBUSY;
		@@ -809,7 +808,6 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen,
		cpuhp_kick_ap_work(cpu);
		}

		hasdied = prev_state != st->state && st->state == CPUHP_OFFLINE;
		out:
		cpu_hotplug_done();
		return ret;

Admin message