Commit 0fe6e20b authored by Naoya Horiguchi's avatar Naoya Horiguchi Committed by Andi Kleen
Browse files

hugetlb, rmap: add reverse mapping for hugepage 



This patch adds reverse mapping feature for hugepage by introducing
mapcount for shared/private-mapped hugepage and anon_vma for
private-mapped hugepage.

While hugepage is not currently swappable, reverse mapping can be useful
for memory error handler.

Without this patch, memory error handler cannot identify processes
using the bad hugepage nor unmap it from them. That is:
- for shared hugepage:
  we can collect processes using a hugepage through pagecache,
  but can not unmap the hugepage because of the lack of mapcount.
- for privately mapped hugepage:
  we can neither collect processes nor unmap the hugepage.
This patch solves these problems.

This patch include the bug fix given by commit 23be7468, so reverts it.

Dependency:
  "hugetlb: move definition of is_vm_hugetlb_page() to hugepage_inline.h"

ChangeLog since May 24.
- create hugetlb_inline.h and move is_vm_hugetlb_index() in it.
- move functions setting up anon_vma for hugepage into mm/rmap.c.

ChangeLog since May 13.
- rebased to 2.6.34
- fix logic error (in case that private mapping and shared mapping coexist)
- move is_vm_hugetlb_page() into include/linux/mm.h to use this function
  from linear_page_index()
- define and use linear_hugepage_index() instead of compound_order()
- use page_move_anon_rmap() in hugetlb_cow()
- copy exclusive switch of __set_page_anon_rmap() into hugepage counterpart.
- revert commit 24be7468 completely

Signed-off-by: default avatarNaoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Larry Woodman <lwoodman@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Acked-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Acked-by: default avatarMel Gorman <mel@csn.ul.ie>
Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
parent 8edf344c

include/linux/hugetlb.h

+1 −0
Original line number Diff line number Diff line
@@ -99,6 +99,7 @@ static inline void hugetlb_report_meminfo(struct seq_file *m) 
#define is_hugepage_only_range(mm, addr, len)	0

#define hugetlb_free_pgd_range(tlb, addr, end, floor, ceiling) ({BUG(); 0; })

#define hugetlb_fault(mm, vma, addr, flags)	({ BUG(); 0; })

#define huge_pte_offset(mm, address)	0



#define hugetlb_change_protection(vma, address, end, newprot)

include/linux/pagemap.h

+7 −1
Original line number Diff line number Diff line
@@ -282,10 +282,16 @@ static inline loff_t page_offset(struct page *page) 
	return ((loff_t)page->index) << PAGE_CACHE_SHIFT;

}



extern pgoff_t linear_hugepage_index(struct vm_area_struct *vma,

				     unsigned long address);



static inline pgoff_t linear_page_index(struct vm_area_struct *vma,

					unsigned long address)

{

	pgoff_t pgoff = (address - vma->vm_start) >> PAGE_SHIFT;

	pgoff_t pgoff;

	if (unlikely(is_vm_hugetlb_page(vma)))

		return linear_hugepage_index(vma, address);

	pgoff = (address - vma->vm_start) >> PAGE_SHIFT;

	pgoff += vma->vm_pgoff;

	return pgoff >> (PAGE_CACHE_SHIFT - PAGE_SHIFT);

}

include/linux/poison.h

+0 −9
Original line number Diff line number Diff line
@@ -48,15 +48,6 @@ 
#define POISON_FREE	0x6b	/* for use-after-free poisoning */

#define	POISON_END	0xa5	/* end-byte of poisoning */



/********** mm/hugetlb.c **********/

/*

 * Private mappings of hugetlb pages use this poisoned value for

 * page->mapping. The core VM should not be doing anything with this mapping

 * but futex requires the existence of some page->mapping value even though it

 * is unused if PAGE_MAPPING_ANON is set.

 */

#define HUGETLB_POISON	((void *)(0x00300300 + POISON_POINTER_DELTA + PAGE_MAPPING_ANON))



/********** arch/$ARCH/mm/init.c **********/

#define POISON_FREE_INITMEM	0xcc

include/linux/rmap.h

+5 −0
Original line number Diff line number Diff line
@@ -140,6 +140,11 @@ void page_add_new_anon_rmap(struct page *, struct vm_area_struct *, unsigned lon 
void page_add_file_rmap(struct page *);

void page_remove_rmap(struct page *);



void hugepage_add_anon_rmap(struct page *, struct vm_area_struct *,

			    unsigned long);

void hugepage_add_new_anon_rmap(struct page *, struct vm_area_struct *,

				unsigned long);



static inline void page_dup_rmap(struct page *page)

{

	atomic_inc(&page->_mapcount);

mm/hugetlb.c

+42 −2
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ 
#include <linux/bootmem.h>

#include <linux/sysfs.h>

#include <linux/slab.h>

#include <linux/rmap.h>



#include <asm/page.h>

#include <asm/pgtable.h>
@@ -220,6 +221,12 @@ static pgoff_t vma_hugecache_offset(struct hstate *h, 
			(vma->vm_pgoff >> huge_page_order(h));

}



pgoff_t linear_hugepage_index(struct vm_area_struct *vma,

				     unsigned long address)

{

	return vma_hugecache_offset(hstate_vma(vma), vma, address);

}



/*

 * Return the size of the pages allocated when backing a VMA. In the majority

 * cases this will be same size as used by the page table entries.
@@ -552,6 +559,7 @@ static void free_huge_page(struct page *page) 
	set_page_private(page, 0);

	page->mapping = NULL;

	BUG_ON(page_count(page));

	BUG_ON(page_mapcount(page));

	INIT_LIST_HEAD(&page->lru);



	spin_lock(&hugetlb_lock);
@@ -2129,6 +2137,7 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src, 
			entry = huge_ptep_get(src_pte);

			ptepage = pte_page(entry);

			get_page(ptepage);

			page_dup_rmap(ptepage);

			set_huge_pte_at(dst, addr, dst_pte, entry);

		}

		spin_unlock(&src->page_table_lock);
@@ -2207,6 +2216,7 @@ void __unmap_hugepage_range(struct vm_area_struct *vma, unsigned long start, 
	flush_tlb_range(vma, start, end);

	mmu_notifier_invalidate_range_end(mm, start, end);

	list_for_each_entry_safe(page, tmp, &page_list, lru) {

		page_remove_rmap(page);

		list_del(&page->lru);

		put_page(page);

	}
@@ -2272,6 +2282,9 @@ static int unmap_ref_private(struct mm_struct *mm, struct vm_area_struct *vma, 
	return 1;

}



/*

 * Hugetlb_cow() should be called with page lock of the original hugepage held.

 */

static int hugetlb_cow(struct mm_struct *mm, struct vm_area_struct *vma,

			unsigned long address, pte_t *ptep, pte_t pte,

			struct page *pagecache_page)
@@ -2286,8 +2299,11 @@ static int hugetlb_cow(struct mm_struct *mm, struct vm_area_struct *vma, 
retry_avoidcopy:

	/* If no-one else is actually using this page, avoid the copy

	 * and just make the page writable */

	avoidcopy = (page_count(old_page) == 1);

	avoidcopy = (page_mapcount(old_page) == 1);

	if (avoidcopy) {

		if (!trylock_page(old_page))

			if (PageAnon(old_page))

				page_move_anon_rmap(old_page, vma, address);

		set_huge_ptep_writable(vma, address, ptep);

		return 0;

	}
@@ -2338,6 +2354,13 @@ retry_avoidcopy: 
		return -PTR_ERR(new_page);

	}



	/*

	 * When the original hugepage is shared one, it does not have

	 * anon_vma prepared.

	 */

	if (unlikely(anon_vma_prepare(vma)))

		return VM_FAULT_OOM;



	copy_huge_page(new_page, old_page, address, vma);

	__SetPageUptodate(new_page);
@@ -2352,6 +2375,8 @@ retry_avoidcopy: 
		huge_ptep_clear_flush(vma, address, ptep);

		set_huge_pte_at(mm, address, ptep,

				make_huge_pte(vma, new_page, 1));

		page_remove_rmap(old_page);

		hugepage_add_anon_rmap(new_page, vma, address);

		/* Make the old page be freed below */

		new_page = old_page;

	}
@@ -2452,10 +2477,17 @@ retry: 
			spin_lock(&inode->i_lock);

			inode->i_blocks += blocks_per_huge_page(h);

			spin_unlock(&inode->i_lock);

			page_dup_rmap(page);

		} else {

			lock_page(page);

			page->mapping = HUGETLB_POISON;

			if (unlikely(anon_vma_prepare(vma))) {

				ret = VM_FAULT_OOM;

				goto backout_unlocked;

			}

			hugepage_add_new_anon_rmap(page, vma, address);

		}

	} else {

		page_dup_rmap(page);

	}



	/*
@@ -2507,6 +2539,7 @@ int hugetlb_fault(struct mm_struct *mm, struct vm_area_struct *vma, 
	pte_t *ptep;

	pte_t entry;

	int ret;

	struct page *page = NULL;

	struct page *pagecache_page = NULL;

	static DEFINE_MUTEX(hugetlb_instantiation_mutex);

	struct hstate *h = hstate_vma(vma);
@@ -2548,6 +2581,11 @@ int hugetlb_fault(struct mm_struct *mm, struct vm_area_struct *vma, 
								vma, address);

	}



	if (!pagecache_page) {

		page = pte_page(entry);

		lock_page(page);

	}



	spin_lock(&mm->page_table_lock);

	/* Check for a racing update before calling hugetlb_cow */

	if (unlikely(!pte_same(entry, huge_ptep_get(ptep))))
@@ -2573,6 +2611,8 @@ out_page_table_lock: 
	if (pagecache_page) {

		unlock_page(pagecache_page);

		put_page(pagecache_page);

	} else {

		unlock_page(page);

	}



out_mutex:

CRA Git | Maintained and supported by SUSTech CRA and CCSE